netdev - Re: [EXT] Re: [PATCH net 2/3] of_net: add property "nvmem-mac-address" for of_get_mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190513080010.GV81826@meh.true.cz>
Date:   Mon, 13 May 2019 10:00:10 +0200
From:   Petr Štetiar <ynezz@...e.cz>
To:     Andy Duan <fugang.duan@....com>
Cc:     Andrew Lunn <andrew@...n.ch>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "john@...ozen.org" <john@...ozen.org>,
        "bgolaszewski@...libre.com" <bgolaszewski@...libre.com>,
        Maxime Ripard <maxime.ripard@...tlin.com>
Subject: Re: [EXT] Re: [PATCH net 2/3] of_net: add property
 "nvmem-mac-address" for of_get_mac_addr()

Andy Duan <fugang.duan@....com> [2019-05-13 03:31:59]:

> From: Andrew Lunn <andrew@...n.ch> Sent: Saturday, May 11, 2019 2:18 AM
> > On Fri, May 10, 2019 at 08:24:03AM +0000, Andy Duan wrote:
> > > If MAC address read from nvmem cell and it is valid mac address,
> > > .of_get_mac_addr_nvmem() add new property "nvmem-mac-address" in
> > > ethernet node. Once user call .of_get_mac_address() to get MAC address
> > > again, it can read valid MAC address from device tree in directly.
> > 
> > I suspect putting the MAC address into OF will go away in a follow up patch. It
> > is a bad idea.
> > 
> >        Andrew
> 
> I don't know the history why does of_get_mac_addr_nvmem() add the new property
> "nvmem-mac-address" into OF. But if it already did that, so the patch add the property
> check in . of_get_mac_address() to avoid multiple read nvmem cells in driver.

it was removed[1] already, more details[2].

1. https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git/commit/?id=265749861a2483263e6cd4c5e305640e4651c110
2. https://patchwork.ozlabs.org/patch/1092248/#2167609

-- ynnezz