netdev - RE: [EXT] Re: [PATCH net 2/3] of_net: add property "nvmem-mac-address" for of_get_mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VI1PR0402MB360046D827C19279B3000810FF0F0@VI1PR0402MB3600.eurprd04.prod.outlook.com>
Date:   Mon, 13 May 2019 08:47:15 +0000
From:   Andy Duan <fugang.duan@....com>
To:     Petr Štetiar <ynezz@...e.cz>
CC:     Andrew Lunn <andrew@...n.ch>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "john@...ozen.org" <john@...ozen.org>,
        "bgolaszewski@...libre.com" <bgolaszewski@...libre.com>,
        Maxime Ripard <maxime.ripard@...tlin.com>
Subject: RE: [EXT] Re: [PATCH net 2/3] of_net: add property
 "nvmem-mac-address" for of_get_mac_addr()

From: Petr Štetiar <ynezz@...e.cz> Sent: Monday, May 13, 2019 4:00 PM
> Andy Duan <fugang.duan@....com> [2019-05-13 03:31:59]:
> 
> > From: Andrew Lunn <andrew@...n.ch> Sent: Saturday, May 11, 2019 2:18
> > AM
> > > On Fri, May 10, 2019 at 08:24:03AM +0000, Andy Duan wrote:
> > > > If MAC address read from nvmem cell and it is valid mac address,
> > > > .of_get_mac_addr_nvmem() add new property "nvmem-mac-address"
> in
> > > > ethernet node. Once user call .of_get_mac_address() to get MAC
> > > > address again, it can read valid MAC address from device tree in directly.
> > >
> > > I suspect putting the MAC address into OF will go away in a follow
> > > up patch. It is a bad idea.
> > >
> > >        Andrew
> >
> > I don't know the history why does of_get_mac_addr_nvmem() add the new
> > property "nvmem-mac-address" into OF. But if it already did that, so
> > the patch add the property check in . of_get_mac_address() to avoid
> multiple read nvmem cells in driver.
> 
> it was removed[1] already, more details[2].
> 
> 1.
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.ker
> nel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Fdavem%2Fnet.git%2Fco
> mmit%2F%3Fid%3D265749861a2483263e6cd4c5e305640e4651c110&amp;d
> ata=02%7C01%7Cfugang.duan%40nxp.com%7Ca9620569af74418a6a1d08d6
> d779076b%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6369333
> 12147303481&amp;sdata=b2BB49WSZDqUfMhCeHobjI%2FLcXLed5sBkXhcR
> uM3mg4%3D&amp;reserved=0
> 2.
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatch
> work.ozlabs.org%2Fpatch%2F1092248%2F%232167609&amp;data=02%7C01
> %7Cfugang.duan%40nxp.com%7Ca9620569af74418a6a1d08d6d779076b%7C
> 686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636933312147313486
> &amp;sdata=Xu7CJyxmOC476k2RiMu2lm6h9juvjEflbztzp1wryuk%3D&amp;re
> served=0
> 
> -- ynnezz

Got it, thanks for your information.
So the patch also can be ignored.

Thanks, Petr Štetiar.