lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CWXP265MB1464BCF96C61A8FD47619AE59E0F0@CWXP265MB1464.GBRP265.PROD.OUTLOOK.COM> Date: Mon, 13 May 2019 10:36:51 +0000 From: Jagdish Motwani <Jagdish.Motwani@...hos.com> To: Pablo Neira Ayuso <pablo@...filter.org>, Jagdish Motwani <j.k.motwani@...il.com> CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>, Florian Westphal <fw@...len.de>, "David S. Miller" <davem@...emloft.net>, "netfilter-devel@...r.kernel.org" <netfilter-devel@...r.kernel.org>, "coreteam@...filter.org" <coreteam@...filter.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: RE: [PATCH net] netfilter: nf_queue:fix reinject verdict handling Hi Pablo, The case I am referring to is : If there are more than 1 hooks returning NF_QUEUE verdict. When the first queue reinjects the packet, 'nf_reinject' starts traversing hooks with hook_index (i). However if it again receives a NF_QUEUE verdict (by some other netfilter hook), it queue with the wrong hook_index. So, when the second queue reinjects the packet, it re-executes some hooks in between the first 2 hooks. Thanks, I will mark : Fixes: 960632ece694 ("netfilter: convert hook list to an array") and update the description also. Regards, Jagdish -----Original Message----- From: Pablo Neira Ayuso <pablo@...filter.org> Sent: Monday, May 13, 2019 2:52 PM To: Jagdish Motwani <j.k.motwani@...il.com> Cc: netdev@...r.kernel.org; Jagdish Motwani <Jagdish.Motwani@...hos.com>; Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>; Florian Westphal <fw@...len.de>; David S. Miller <davem@...emloft.net>; netfilter-devel@...r.kernel.org; coreteam@...filter.org; linux-kernel@...r.kernel.org Subject: Re: [PATCH net] netfilter: nf_queue:fix reinject verdict handling Hi Jagdish, On Thu, May 09, 2019 at 12:01:14AM +0530, Jagdish Motwani wrote: > From: Jagdish Motwani <jagdish.motwani@...hos.com> > > In case of more than 1 nf_queues, hooks between them are being > executed more than once. This refers to NF_REPEAT, correct? I think this broke with 960632ece6949. If so, it would be good to add the following tag to this patch then. It's useful for robots collecting fixes for -stable kernels. Fixes: 960632ece694 ("netfilter: convert hook list to an array") > Signed-off-by: Jagdish Motwani <jagdish.motwani@...hos.com> Thanks. ________________________________ Sophos Technologies Private Limited Regd. Office: Sophos House, Saigulshan Complex, Beside White House, Panchvati Cross Road, Ahmedabad - 380006, Gujarat, India CIN: U72200GJ2006PTC047857 Sophos Ltd, a company registered in England and Wales number 2096520, The Pentagon, Abingdon Science Park, Abingdon, OX14 3YP, United Kingdom.
Powered by blists - more mailing lists