netdev - Re: [RFC PATCH net-next 3/3] flow_offload: support CVLAN match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <62a0f0f9-d576-baa6-f34d-f4875214ea7d@solarflare.com>
Date:   Mon, 13 May 2019 14:28:09 +0100
From:   Edward Cree <ecree@...arflare.com>
To:     Jianbo Liu <jianbol@...lanox.com>
CC:     netdev <netdev@...r.kernel.org>
Subject: Re: [RFC PATCH net-next 3/3] flow_offload: support CVLAN match

On 13/05/2019 13:54, Jianbo Liu wrote:
> Could you please push to 5.1 and 5.0-stable? The original patch brought a bug
> in mlx5_core driver. Need your patch to fix.
>
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> @@ -1615,7 +1615,7 @@ static int __parse_cls_flower(struct mlx5e_priv *priv,
>         if (flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_CVLAN)) {
>                 struct flow_match_vlan match;
>
> -               flow_rule_match_vlan(rule, &match);
> +               flow_rule_match_cvlan(rule, &match);
>                 if (match.mask->vlan_id ||
>                     match.mask->vlan_priority ||
>                     match.mask->vlan_tpid) {
>
> Thanks!
My patch will be more easily accepted with a user in-tree, so could
 you give this fix a commit message and SOB?  Then I'll roll it into
 my next posting of this series, thanks!

-Ed