netdev - Re: [PATCH RFC net-next] netlink: Add support for timestamping messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b0b5dccd-cab0-9896-d6ef-d5f586fbbf9e@gmail.com>
Date:   Mon, 13 May 2019 20:53:30 -0600
From:   David Ahern <dsahern@...il.com>
To:     Willem de Bruijn <willemdebruijn.kernel@...il.com>
Cc:     David Miller <davem@...emloft.net>,
        Network Development <netdev@...r.kernel.org>,
        Eric Dumazet <eric.dumazet@...il.com>
Subject: Re: [PATCH RFC net-next] netlink: Add support for timestamping
 messages

On 5/13/19 9:31 AM, Willem de Bruijn wrote:
>>
>> +/* based on tcp_recv_timestamp */
> 
> Which itself is based on __sock_recv_timestamp. Which this resembles
> even more closely, as both pass an skb. Instead of duplicating the
> core code yet again, we can probably factor out and reuse it. Netlink
> only does not need the SOF_TIMESTAMPING part.
> 
> 

agreed. My original version went down that path. I'll take another look
for v2.