netdev - Re: [RFC net-next v2 00/14] net: stmmac: Selftests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190514.110919.1280826013505735007.davem@davemloft.net>
Date:   Tue, 14 May 2019 11:09:19 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     Jose.Abreu@...opsys.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Joao.Pinto@...opsys.com, peppe.cavallaro@...com,
        alexandre.torgue@...com, clabbe.montjoie@...il.com, andrew@...n.ch
Subject: Re: [RFC net-next v2 00/14] net: stmmac: Selftests

From: Jose Abreu <Jose.Abreu@...opsys.com>
Date: Tue, 14 May 2019 17:45:22 +0200

> [ Submitting with net-next closed for proper review and testing. ]
> 
> This introduces selftests support in stmmac driver. We add 9 basic sanity
> checks and MAC loopback support for all cores within the driver. This way
> more tests can easily be added in the future and can be run in virtually
> any MAC/GMAC/QoS/XGMAC platform.
> 
> Having this we can find regressions and missing features in the driver
> while at the same time we can check if the IP is correctly working.
> 
> We have been using this for some time now and I do have more tests to
> submit in the feature. My experience is that although writing the tests
> adds more development time, the gain results are obvious.
> 
> I let this feature optional within the driver under a Kconfig option.

Generally, this series looks fine to me.