lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20190514163243.3f2a420f@cakuba.netronome.com> Date: Tue, 14 May 2019 16:32:43 -0700 From: Jakub Kicinski <jakub.kicinski@...ronome.com> To: Maxim Mikityanskiy <maximmi@...lanox.com> Cc: "David S. Miller" <davem@...emloft.net>, Alexey Kuznetsov <kuznet@....inr.ac.ru>, Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Leon Romanovsky <leonro@...lanox.com> Subject: Re: [RFC 2] Validate required parameters in inet6_validate_link_af On Mon, 13 May 2019 15:05:30 +0000, Maxim Mikityanskiy wrote: > + err = -EINVAL; > + > + if (tb[IFLA_INET6_ADDR_GEN_MODE]) { > + u8 mode = nla_get_u8(tb[IFLA_INET6_ADDR_GEN_MODE]); > + > + if (check_addr_gen_mode(mode) < 0) > + return -EINVAL; > + if (dev && check_stable_privacy(idev, dev_net(dev), mode) < 0) > + return -EINVAL; > + > + err = 0; > + } > + > + if (tb[IFLA_INET6_TOKEN]) > + err = 0; > + > + return err; While at it could you forgo the retval optimization? Most of the time it just leads to less readable code for no gain. The normal way to write this code would be: if (!tb[IFLA_INET6_ADDR_GEN_MODE] && !tb[IFLA_INET6_TOKEN]) return -EINVAL; if (tb[IFLA_INET6_ADDR_GEN_MODE]) { u8 mode = nla_get_u8(tb[IFLA_INET6_ADDR_GEN_MODE]); if (check_addr_gen_mode(mode) < 0) return -EINVAL; if (dev && check_stable_privacy(idev, dev_net(dev), mode) < 0) return -EINVAL; } return 0;
Powered by blists - more mailing lists