netdev - Re: [PATCH net-next] net: stmmac: socfpga: add RMII phy mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190515163041.GB24455@lunn.ch>
Date:   Wed, 15 May 2019 18:30:41 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     Dinh Nguyen <dinguyen@...nel.org>, netdev@...r.kernel.org,
        davem@...emloft.net, joabreu@...opsys.com,
        Wei Liang Lim <wei.liang.lim@...el.com>
Subject: Re: [PATCH net-next] net: stmmac: socfpga: add RMII phy mode

On Wed, May 15, 2019 at 09:18:15AM -0700, Florian Fainelli wrote:
> On 5/15/19 8:24 AM, Andrew Lunn wrote:
> >> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
> >> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
> >> @@ -251,6 +251,9 @@ static int socfpga_dwmac_set_phy_mode(struct socfpga_dwmac *dwmac)
> >>  	case PHY_INTERFACE_MODE_SGMII:
> >>  		val = SYSMGR_EMACGRP_CTRL_PHYSEL_ENUM_GMII_MII;
> >>  		break;
> >> +	case PHY_INTERFACE_MODE_RMII:
> >> +		val = SYSMGR_EMACGRP_CTRL_PHYSEL_ENUM_RMII;
> >> +		break;
> > 
> > What about PHY_INTERFACE_MODE_RMII_ID, PHY_INTERFACE_MODE_RMII_RXID,
> > PHY_INTERFACE_MODE_RMII_TXID?
> 
> RMII is reduced MII not Reduced Gigabit MII (RGMII), which still
> operates at MII speed, therefore no concept of internal deal for RX/TX
> data lines, the change looks fine to me.

Upps, yes. Missed the missing G!

Sorry  for the noise.

       Andrew