netdev - Re: [PATCH net] tcp: do not recycle cloned skbs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190515.094150.697892727321848072.davem@davemloft.net>
Date:   Wed, 15 May 2019 09:41:50 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, willemb@...gle.com, eric.dumazet@...il.com
Subject: Re: [PATCH net] tcp: do not recycle cloned skbs

From: Eric Dumazet <edumazet@...gle.com>
Date: Wed, 15 May 2019 09:26:54 -0700

> On Wed, May 15, 2019 at 9:24 AM David Miller <davem@...emloft.net> wrote:
>>
>> From: Eric Dumazet <edumazet@...gle.com>
>> Date: Wed, 15 May 2019 09:10:15 -0700
>>
>> > It is illegal to change arbitrary fields in skb_shared_info if the
>> > skb is cloned.
>> >
>> > Before calling skb_zcopy_clear() we need to ensure this rule,
>> > therefore we need to move the test from sk_stream_alloc_skb()
>> > to sk_wmem_free_skb()
>> >
>> > Fixes: 4f661542a402 ("tcp: fix zerocopy and notsent_lowat issues")
>> > Signed-off-by: Eric Dumazet <edumazet@...gle.com>
>> > Diagnosed-by: Willem de Bruijn <willemb@...gle.com>
>>
>> Applied and queued up for -stable.
> 
> Note the patch targets current net tree, but does not need to be
> backported to older kernel versions
> (4f661542a402 is only in upcoming 5.2)

Doesn't it fix a fix for something in 5.0?