netdev - Re: [PATCH 2/3] aqc111: fix writing to the phy on BE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <00719f72-280b-418f-235d-8bf0215d484e@aquantia.com>
Date:   Wed, 15 May 2019 14:16:11 +0000
From:   Igor Russkikh <Igor.Russkikh@...antia.com>
To:     Oliver Neukum <oneukum@...e.com>,
        Dmitry Bezrukov <Dmitry.Bezrukov@...antia.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH 2/3] aqc111: fix writing to the phy on BE


>>> -	aqc111_write32_cmd(dev, AQ_PHY_OPS, 0, 0, &aqc111_data->phy_cfg);
>>> +	phy_on_the_wire = aqc111_data->phy_cfg;
>>> +	aqc111_write32_cmd(dev, AQ_PHY_OPS, 0, 0, &phy_on_the_wire);
>>
>> Hi Oliver,
>>
>> I see all write32_cmd and write16_cmd are using a temporary variable to do an
>> internal cpu_to_le32. Why this extra temporary storage is needed?
>>
>> The question is actually for both 2nd and third patch.
>> In all the cases BE machine will store temporary bswap conversion in tmp
>> variable and will not actually touch actual field.
> 
> Hi,
> 
> I am most terribly sorry. I overlooked the copy. Shall I revert or will
> you.
> 
> 	Sorry
> 		Oliver

Hi Oliver,

I'll submit the reverts.

Regards,
  Igor