netdev - Re: [PATCH] igb: add parameter to ignore nvm checksum validation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9be117dc6e818ab83376cd8e0f79dbfaaf193aa9.camel@intel.com>
Date:   Thu, 16 May 2019 12:35:27 -0700
From:   Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:     Nikunj Kela <nkela@...co.com>
Cc:     xe-linux-external@...co.com,
        "David S. Miller" <davem@...emloft.net>,
        intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] igb: add parameter to ignore nvm checksum validation

On Wed, 2019-05-08 at 23:14 +0000, Nikunj Kela wrote:
> Some of the broken NICs don't have EEPROM programmed correctly. It
> results
> in probe to fail. This change adds a module parameter that can be
> used to
> ignore nvm checksum validation.
> 
> Cc: xe-linux-external@...co.com
> Signed-off-by: Nikunj Kela <nkela@...co.com>
> ---
>  drivers/net/ethernet/intel/igb/igb_main.c | 28
> ++++++++++++++++++++++------
>  1 file changed, 22 insertions(+), 6 deletions(-)

NAK for two reasons.  First, module parameters are not desirable
because their individual to one driver and a global solution should be
found so that all networking device drivers can use the solution.  This
will keep the interface to change/setup/modify networking drivers
consistent for all drivers.

Second and more importantly, if your NIC is broken, fix it.  Do not try
and create a software workaround so that you can continue to use a
broken NIC.  There are methods/tools available to properly reprogram
the EEPROM on a NIC, which is the right solution for your issue.

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)