netdev - Re: [bpf PATCH] net: tcp_bpf, correctly handle DONT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e3c7810a-0a54-2f9b-707d-b87ff5080904@iogearbox.net>
Date:   Thu, 16 May 2019 01:42:53 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     John Fastabend <john.fastabend@...il.com>, ast@...nel.org
Cc:     netdev@...r.kernel.org, bpf@...r.kernel.org
Subject: Re: [bpf PATCH] net: tcp_bpf, correctly handle DONT_WAIT flags and
 timeo == 0

On 05/14/2019 06:42 AM, John Fastabend wrote:
> The tcp_bpf_wait_data() routine needs to check timeo != 0 before
> calling sk_wait_event() otherwise we may see unexpected stalls
> on receiver.
> 
> Arika did all the leg work here I just formaatted, posted and ran
> a few tests.
> 
> Fixes: 604326b41a6fb ("bpf, sockmap: convert to generic sk_msg interface")
> Reported-by: Arika Chen <eaglesora@...il.com>
> Suggested-by: Arika Chen <eaglesora@...il.com>
> Signed-off-by: John Fastabend <john.fastabend@...il.com>

Applied, thanks!