netdev - Re: [PATCH net 3/4] vhost: vsock: add weight support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <70c24182-9238-1a69-8e35-53c98b957bc7@redhat.com>
Date:   Fri, 17 May 2019 09:05:30 +0800
From:   Jason Wang <jasowang@...hat.com>
To:     Stefan Hajnoczi <stefanha@...hat.com>
Cc:     mst@...hat.com, virtualization@...ts.linux-foundation.org,
        kvm@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, pbonzini@...hat.com
Subject: Re: [PATCH net 3/4] vhost: vsock: add weight support


On 2019/5/16 下午5:33, Stefan Hajnoczi wrote:
> On Thu, May 16, 2019 at 03:47:41AM -0400, Jason Wang wrote:
>> @@ -183,7 +184,8 @@ static struct vhost_vsock *vhost_vsock_get(u32 guest_cid)
>>   		virtio_transport_deliver_tap_pkt(pkt);
>>   
>>   		virtio_transport_free_pkt(pkt);
>> -	}
>> +		total_len += pkt->len;
> Please increment total_len before virtio_transport_free_pkt(pkt) to
> avoid use-after-free.


Right, let me fix this.

Thanks