lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 17 May 2019 10:57:51 -0700 From: Stephen Hemminger <stephen@...workplumber.org> To: David Ahern <dsahern@...il.com> Cc: Nir Weiner <nir.weiner@...cle.com>, netdev@...r.kernel.org, liran.alon@...cle.com Subject: Re: [iproute2 2/3] tc: jsonify tbf qdisc parameters On Fri, 17 May 2019 11:35:16 -0600 David Ahern <dsahern@...il.com> wrote: > On 5/6/19 10:18 AM, Nir Weiner wrote: > > > if (prate64) { > > - fprintf(f, "peakrate %s ", sprint_rate(prate64, b1)); > > + print_string(PRINT_ANY, "peakrate", "peakrate %s ", sprint_rate(prate64, b1)); > > if (qopt->mtu || qopt->peakrate.mpu) { > > mtu = tc_calc_xmitsize(prate64, qopt->mtu); > > if (show_details) { > > fprintf(f, "mtu %s/%u mpu %s ", sprint_size(mtu, b1), > > 1<<qopt->peakrate.cell_log, sprint_size(qopt->peakrate.mpu, b2)); > > > The fprintf under show_details should be converted as well. This applies > to patch 1 as well. > > And, please add example output to each patch. One trick I used was scanning for all calls to fprintf(f and replacing them
Powered by blists - more mailing lists