netdev - Re: [RFC PATCH v2 net-next 1/3] flow_offload: copy tcfa_index into flow_action

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 18 May 2019 16:30:59 -0400
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Edward Cree <ecree@...arflare.com>, Jiri Pirko <jiri@...nulli.us>,
        Pablo Neira Ayuso <pablo@...filter.org>,
        David Miller <davem@...emloft.net>
Cc:     netdev <netdev@...r.kernel.org>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Andy Gospodarek <andy@...yhouse.net>,
        Jakub Kicinski <jakub.kicinski@...ronome.com>,
        Michael Chan <michael.chan@...adcom.com>,
        Vishal Kulkarni <vishal@...lsio.com>
Subject: Re: [RFC PATCH v2 net-next 1/3] flow_offload: copy tcfa_index into
 flow_action_entry

On 2019-05-15 3:42 p.m., Edward Cree wrote:
> Required for support of shared counters (and possibly other shared per-
>   action entities in future).
> 
> Signed-off-by: Edward Cree <ecree@...arflare.com>
> ---
>   include/net/flow_offload.h | 1 +
>   net/sched/cls_api.c        | 1 +
>   2 files changed, 2 insertions(+)
> 
> diff --git a/include/net/flow_offload.h b/include/net/flow_offload.h
> index 6200900434e1..4ee0f68f2e8d 100644
> --- a/include/net/flow_offload.h
> +++ b/include/net/flow_offload.h
> @@ -137,6 +137,7 @@ enum flow_action_mangle_base {
>   
>   struct flow_action_entry {
>   	enum flow_action_id		id;
> +	u32				action_index;
>   	union {
>   		u32			chain_index;	/* FLOW_ACTION_GOTO */
>   		struct net_device	*dev;		/* FLOW_ACTION_REDIRECT */
> diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c
> index d4699156974a..0d498c3815f5 100644
> --- a/net/sched/cls_api.c
> +++ b/net/sched/cls_api.c
> @@ -3195,6 +3195,7 @@ int tc_setup_flow_action(struct flow_action *flow_action,
>   		struct flow_action_entry *entry;
>   
>   		entry = &flow_action->entries[j];
> +		entry->action_index = act->tcfa_index;
>   		if (is_tcf_gact_ok(act)) {
>   			entry->id = FLOW_ACTION_ACCEPT;
>   		} else if (is_tcf_gact_shot(act)) {


LGTM.

cheers,
jamal