netdev - Re: [PATCH 0/3] resolve module name conflict for asix PHY and USB modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cf0f6da1-efd5-1d28-0141-5082f8b2bea1@gmail.com>
Date:   Sat, 18 May 2019 13:17:25 +1200
From:   Michael Schmitz <schmitzmic@...il.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     netdev@...r.kernel.org, sfr@...b.auug.org.au, davem@...emloft.net
Subject: Re: [PATCH 0/3] resolve module name conflict for asix PHY and USB
 modules

Thanks Andrew,

makes perfect sense - patch resent.

Cheers,

	Michael

Am 18.05.2019 um 09:20 schrieb Andrew Lunn:
> On Sat, May 18, 2019 at 08:25:15AM +1200, Michael Schmitz wrote:
>> Haven't heard back in a while, so here goes:
>>
>> Commit 31dd83b96641 ("net-next: phy: new Asix Electronics PHY driver")
>> introduced a new PHY driver drivers/net/phy/asix.c that causes a module
>> name conflict with a pre-existiting driver (drivers/net/usb/asix.c).
>>
>> The PHY driver is used by the X-Surf 100 ethernet card driver, and loaded
>> by that driver via its PHY ID. A rename of the driver looks unproblematic.
>>
>> Rename PHY driver to ax88796b.c in order to resolve name conflict.
>
> Hi Michael
>
> Please just use git mv and do it all one patch. It then makes it clear
> you have not changed the driver, just renamed it.
>
> Thanks
> 	Andrew
>