lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 20 May 2019 10:45:54 -0700 (PDT) From: David Miller <davem@...emloft.net> To: hujunwei4@...wei.com Cc: jon.maloy@...csson.com, ying.xue@...driver.com, willemdebruijn.kernel@...il.com, sfr@...b.auug.org.au, netdev@...r.kernel.org, tipc-discussion@...ts.sourceforge.net, linux-kernel@...r.kernel.org, mingfangsen@...wei.com Subject: Re: [PATCH v4] tipc: fix modprobe tipc failed after switch order of device registration From: hujunwei <hujunwei4@...wei.com> Date: Mon, 20 May 2019 14:43:59 +0800 > From: Junwei Hu <hujunwei4@...wei.com> > > Error message printed: > modprobe: ERROR: could not insert 'tipc': Address family not > supported by protocol. > when modprobe tipc after the following patch: switch order of > device registration, commit 7e27e8d6130c > ("tipc: switch order of device registration to fix a crash") > > Because sock_create_kern(net, AF_TIPC, ...) called by > tipc_topsrv_create_listener() in the initialization process > of tipc_init_net(), so tipc_socket_init() must be execute before that. > Meanwhile, tipc_net_id need to be initialized when sock_create() > called, and tipc_socket_init() is no need to be called for each namespace. > > I add a variable tipc_topsrv_net_ops, and split the > register_pernet_subsys() of tipc into two parts, and split > tipc_socket_init() with initialization of pernet params. > > By the way, I fixed resources rollback error when tipc_bcast_init() > failed in tipc_init_net(). > > Fixes: 7e27e8d6130c ("tipc: switch order of device registration to fix a crash") > Signed-off-by: Junwei Hu <hujunwei4@...wei.com> > Reported-by: Wang Wang <wangwang2@...wei.com> > Reported-by: syzbot+1e8114b61079bfe9cbc5@...kaller.appspotmail.com > Reviewed-by: Kang Zhou <zhoukang7@...wei.com> > Reviewed-by: Suanming Mou <mousuanming@...wei.com> Applied.
Powered by blists - more mailing lists