lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 20 May 2019 23:20:41 +0200
From:   Andrew Lunn <>
To:     Weifeng Voon <>
Cc:     "David S. Miller" <>,
        Maxime Coquelin <>,,,
        Jose Abreu <>,
        Giuseppe Cavallaro <>,
        Alexandre Torgue <>,
        Ong Boon Leong <>,
        Tan Tee Min <>
Subject: Re: [PATCH net] net: stmmac: fix ethtool flow control not able to

On Tue, May 21, 2019 at 12:55:42PM +0800, Weifeng Voon wrote:
> From: "Tan, Tee Min" <>
> Currently ethtool was not able to get/set the flow control due to a
> missing "!". It will always return -EOPNOTSUPP even the device is
> flow control supported.
> This patch fixes the condition check for ethtool flow control get/set
> function for ETHTOOL_LINK_MODE_Asym_Pause_BIT.
> Fixes: 3c1bcc8614db (“net: ethernet: Convert phydev advertize and supported from u32 to link mode”)
> Signed-off-by: Tan, Tee Min <>
> Reviewed-by: Ong Boon Leong <>
> Signed-off-by: Voon, Weifeng <>

Upps,  my bad. Sorry.

Reviewed-by: Andrew Lunn <>


Powered by blists - more mailing lists