netdev - Re: [PATCH iproute2-next] treewide: refactor help messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e363c59b-585b-b596-f588-3d9fd3c3b624@gmail.com>
Date:   Mon, 20 May 2019 15:38:06 -0600
From:   David Ahern <dsahern@...il.com>
To:     Matteo Croce <mcroce@...hat.com>, netdev@...r.kernel.org
Cc:     Stephen Hemminger <stephen@...workplumber.org>
Subject: Re: [PATCH iproute2-next] treewide: refactor help messages

On 5/17/19 7:38 AM, Matteo Croce wrote:
> Every tool in the iproute2 package have one or more function to show
> an help message to the user. Some of these functions print the help
> line by line with a series of printf call, e.g. ip/xfrm_state.c does
> 60 fprintf calls.
> If we group all the calls to a single one and just concatenate strings,
> we save a lot of libc calls and thus object size. The size difference
> of the compiled binaries calculated with bloat-o-meter is:
> 

...

> 
> While at it, indent some strings which were starting at column 0,
> and use tabs where possible, to have a consistent style across helps.
> 
> Signed-off-by: Matteo Croce <mcroce@...hat.com>
> ---

applied to iproute2-next. Thanks for taking the time to clean this up.