netdev - Re: [PATCH net 1/2] selftests: fib_rule_tests: fix local IPv4 address typo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 20 May 2019 15:42:23 -0600
From:   David Ahern <dsahern@...il.com>
To:     Hangbin Liu <liuhangbin@...il.com>, netdev@...r.kernel.org
Cc:     Roopa Prabhu <roopa@...ulusnetworks.com>, davem@...emloft.net
Subject: Re: [PATCH net 1/2] selftests: fib_rule_tests: fix local IPv4 address
 typo

On 5/19/19 10:36 PM, Hangbin Liu wrote:
> The IPv4 testing address are all in 192.51.100.0 subnet. It doesn't make
> sense to set a 198.51.100.1 local address. Should be a typo.

The unused DEV_ADDR suggests you are correct. That should be removed as
well or the IPv6 address encoded and used for consistency.

> 
> Fixes: 65b2b4939a64 ("selftests: net: initial fib rule tests")
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>
> ---
>  tools/testing/selftests/net/fib_rule_tests.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/net/fib_rule_tests.sh b/tools/testing/selftests/net/fib_rule_tests.sh
> index 4b7e107865bf..1ba069967fa2 100755
> --- a/tools/testing/selftests/net/fib_rule_tests.sh
> +++ b/tools/testing/selftests/net/fib_rule_tests.sh
> @@ -55,7 +55,7 @@ setup()
>  
>  	$IP link add dummy0 type dummy
>  	$IP link set dev dummy0 up
> -	$IP address add 198.51.100.1/24 dev dummy0
> +	$IP address add 192.51.100.1/24 dev dummy0
>  	$IP -6 address add 2001:db8:1::1/64 dev dummy0
>  
>  	set +e
> 

Reviewed-by: David Ahern <dsahern@...il.com>