netdev - Re: [PATCH net] ipv6: Consider sk_bound_dev_if when binding a raw socket to an address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8b6e12cf-08b7-d625-325e-ffacf3db7f26@gmail.com>
Date:   Mon, 20 May 2019 16:16:20 -0600
From:   David Ahern <dsahern@...il.com>
To:     Mike Manning <mmanning@...tta.att-mail.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net] ipv6: Consider sk_bound_dev_if when binding a raw
 socket to an address

On 5/20/19 12:57 PM, Mike Manning wrote:
> IPv6 does not consider if the socket is bound to a device when binding
> to an address. The result is that a socket can be bound to eth0 and
> then bound to the address of eth1. If the device is a VRF, the result
> is that a socket can only be bound to an address in the default VRF.
> 
> Resolve by considering the device if sk_bound_dev_if is set.
> 
> Signed-off-by: Mike Manning <mmanning@...tta.att-mail.com>
> ---
>  net/ipv6/raw.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/net/ipv6/raw.c b/net/ipv6/raw.c
> index 84dbe21b71e5..96a3559f2a09 100644
> --- a/net/ipv6/raw.c
> +++ b/net/ipv6/raw.c
> @@ -287,7 +287,9 @@ static int rawv6_bind(struct sock *sk, struct sockaddr *uaddr, int addr_len)
>  			/* Binding to link-local address requires an interface */
>  			if (!sk->sk_bound_dev_if)
>  				goto out_unlock;
> +		}
>  
> +		if (sk->sk_bound_dev_if) {
>  			err = -ENODEV;
>  			dev = dev_get_by_index_rcu(sock_net(sk),
>  						   sk->sk_bound_dev_if);
> 

Reviewed-by: David Ahern <dsahern@...il.com>
Tested-by: David Ahern <dsahern@...il.com>