netdev - Re: [PATCH 4.9 41/51] fib_rules: return 0 directly if an exactly same rule exists when NLM_F

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 19 May 2019 18:29:19 -0600
From:   David Ahern <dsahern@...il.com>
To:     Nathan Chancellor <natechancellor@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Thomas Haller <thaller@...hat.com>,
        Hangbin Liu <liuhangbin@...il.com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH 4.9 41/51] fib_rules: return 0 directly if an exactly same
 rule exists when NLM_F_EXCL not supplied

On 5/19/19 9:43 AM, Nathan Chancellor wrote:
> Hi all,
> 
> This commit is causing issues on Android devices when Wi-Fi and mobile
> data are both enabled. The device will do a soft reboot consistently.
> So far, I've had reports on the Pixel 3 XL, OnePlus 6, Pocophone, and
> Note 9 and I can reproduce on my OnePlus 6.
> 
> Sorry for taking so long to report this, I just figured out how to
> reproduce it today and I didn't want to report it without that.
> 
> Attached is a full dmesg and the relevant snippet from Android's logcat.
> 
> Let me know what I can do to help debug,
> Nathan
> 

It's a backport problem. err needs to be reset to 0 before the goto.