netdev - Re: [PATCH] net: qrtr: Fix message type of outgoing packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190520.205316.2191376307434511568.davem@davemloft.net>
Date:   Mon, 20 May 2019 20:53:16 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     bjorn.andersson@...aro.org
Cc:     aneela@...eaurora.org, hofrat@...dl.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH] net: qrtr: Fix message type of outgoing packets

From: Bjorn Andersson <bjorn.andersson@...aro.org>
Date: Mon, 20 May 2019 16:51:56 -0700

> QRTR packets has a message type in the header, which is repeated in the
> control header. For control packets we therefor copy the type from
> beginning of the outgoing payload and use that as message type.
> 
> For non-control messages an endianness fix introduced in v5.2-rc1 caused the
> type to be 0, rather than QRTR_TYPE_DATA, causing all messages to be dropped by
> the receiver. Fix this by converting and using qrtr_type, which will remain
> QRTR_TYPE_DATA for non-control messages.
> 
> Fixes: 8f5e24514cbd ("net: qrtr: use protocol endiannes variable")
> Signed-off-by: Bjorn Andersson <bjorn.andersson@...aro.org>

Applied, thank you.