netdev - Re: [PATCH RFC] net: qualcomm: rmnet: Move common struct definitions to include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 21 May 2019 22:45:46 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Subash Abhinov Kasiviswanathan <subashab@...eaurora.org>
Cc:     Alex Elder <elder@...aro.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        David Miller <davem@...emloft.net>,
        Networking <netdev@...r.kernel.org>
Subject: Re: [PATCH RFC] net: qualcomm: rmnet: Move common struct definitions
 to include

On Tue, May 21, 2019 at 9:35 PM Subash Abhinov Kasiviswanathan
<subashab@...eaurora.org> wrote:
>
> Create if_rmnet.h and move the rmnet MAP packet structs to this
> common include file. To account for portability, add little and
> big endian bitfield definitions similar to the ip & tcp headers.
>
> The definitions in the headers can now be re-used by the
> upcoming ipa driver series as well as qmi_wwan.
>
> Signed-off-by: Subash Abhinov Kasiviswanathan <subashab@...eaurora.org>
> ---
> This patch is an alternate implementation of the series posted by Elder.
> This eliminates the changes needed in the rmnet packet parsing
> while maintaining portability.
> ---

I think I'd just duplicate the structure definitions then, to avoid having
the bitfield definitions in a common header and using them in the new
driver.

       Arnd