lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 20 May 2019 20:12:02 -0400 (EDT) From: David Miller <davem@...emloft.net> To: felipe@...ipegasper.com Cc: viro@...iv.linux.org.uk, linux-kernel@...r.kernel.org, netdev@...r.kernel.org, linux-api@...r.kernel.org Subject: Re: [PATCH v3] net: Add UNIX_DIAG_UID to Netlink UNIX socket diagnostics. From: Felipe Gasper <felipe@...ipegasper.com> Date: Sat, 18 May 2019 20:38:39 -0500 > Author: Felipe Gasper <felipe@...ipegasper.com> > Date: Sat May 18 20:04:40 2019 -0500 > > net: Add UNIX_DIAG_UID to Netlink UNIX socket diagnostics. Please format your patch submission properly. This Author: and Date: should not be here in the commit message. The "net: Add UNIX_DIAG_UID to Netlink UNIX socket diagnostics." should be exclusively in your Subject line. And: > This adds the ability for Netlink to report a socket's UID along with the > other UNIX diagnostic information that is already available. This will > allow diagnostic tools greater insight into which users control which > socket. > > To test this, do the following as a non-root user: > > unshare -U -r bash > nc -l -U user.socket.$$ & > > .. and verify from within that same session that Netlink UNIX socket > diagnostics report the socket's UID as 0. Also verify that Netlink UNIX > socket diagnostics report the socket's UID as the user's UID from an > unprivileged process in a different session. Verify the same from > a root process. > > Signed-off-by: Felipe Gasper <felipe@...ipegasper.com> This is all unnecessarily indented. I know what you did, you took something like "git show" output and just posted it to the list here. But that's not what you're supposed to do. Thanks.
Powered by blists - more mailing lists