netdev - Re: [PATCH] Documentation/networking: fix af

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 21 May 2019 15:23:13 +0200
From:   Björn Töpel <bjorn.topel@...il.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        David Miller <davem@...emloft.net>,
        Magnus Karlsson <magnus.karlsson@...el.com>,
        Daniel Borkmann <daniel@...earbox.net>
Subject: Re: [PATCH] Documentation/networking: fix af_xdp.rst Sphinx warnings

On Mon, 20 May 2019 at 23:23, Randy Dunlap <rdunlap@...radead.org> wrote:
>
> From: Randy Dunlap <rdunlap@...radead.org>
>
> Fix Sphinx warnings in Documentation/networking/af_xdp.rst by
> adding indentation:
>
> Documentation/networking/af_xdp.rst:319: WARNING: Literal block expected; none found.
> Documentation/networking/af_xdp.rst:326: WARNING: Literal block expected; none found.
>
> Fixes: 0f4a9b7d4ecb ("xsk: add FAQ to facilitate for first time users")
>
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Magnus Karlsson <magnus.karlsson@...el.com>
> Cc: Daniel Borkmann <daniel@...earbox.net>
> ---
>  Documentation/networking/af_xdp.rst |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> --- lnx-52-rc1.orig/Documentation/networking/af_xdp.rst
> +++ lnx-52-rc1/Documentation/networking/af_xdp.rst
> @@ -316,16 +316,16 @@ A: When a netdev of a physical NIC is in
>     all the traffic, you can force the netdev to only have 1 queue, queue
>     id 0, and then bind to queue 0. You can use ethtool to do this::
>
> -   sudo ethtool -L <interface> combined 1
> +     sudo ethtool -L <interface> combined 1
>
>     If you want to only see part of the traffic, you can program the
>     NIC through ethtool to filter out your traffic to a single queue id
>     that you can bind your XDP socket to. Here is one example in which
>     UDP traffic to and from port 4242 are sent to queue 2::
>
> -   sudo ethtool -N <interface> rx-flow-hash udp4 fn
> -   sudo ethtool -N <interface> flow-type udp4 src-port 4242 dst-port \
> -   4242 action 2
> +     sudo ethtool -N <interface> rx-flow-hash udp4 fn
> +     sudo ethtool -N <interface> flow-type udp4 src-port 4242 dst-port \
> +     4242 action 2
>
>     A number of other ways are possible all up to the capabilitites of
>     the NIC you have.
>
>

Acked-by: Björn Töpel <bjorn.topel@...el.com>