netdev - Re: [PATCH] net: phy: lxt: Add suspend/resume support to LXT971 and LXT973.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <15504aa9-092c-c3b0-4dbe-32b9cc8dff39@gmail.com>
Date:   Wed, 22 May 2019 20:25:19 +0200
From:   Heiner Kallweit <hkallweit1@...il.com>
To:     Christophe Leroy <christophe.leroy@....fr>,
        Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] net: phy: lxt: Add suspend/resume support to LXT971 and
 LXT973.

On 22.05.2019 12:01, Christophe Leroy wrote:
> All LXT PHYs implement the standard "power down" bit 11 of
> BMCR, so this patch adds support using the generic
> genphy_{suspend,resume} functions.
> 
> LXT970 is left aside because all registers get cleared upon
> "power down" exit.
> 
> Fixes: 0f0ca340e57b ("phy: power management support")
> Signed-off-by: Christophe Leroy <christophe.leroy@....fr>
The patch should be annotated net-next, and I would recommend
to remove the Fixes tag, because it doesn't fix an actual issue
and I see it rather as an improvement. Apart from that:

Reviewed-by: Heiner Kallweit <hkallweit1@...il.com>