netdev - Re: [PATCH net v2] Validate required parameters in inet6_validate_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190522.120748.42244348495685617.davem@davemloft.net>
Date:   Wed, 22 May 2019 12:07:48 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     maximmi@...lanox.com
Cc:     jakub.kicinski@...ronome.com, kuznet@....inr.ac.ru,
        yoshfuji@...ux-ipv6.org, netdev@...r.kernel.org,
        leonro@...lanox.com
Subject: Re: [PATCH net v2] Validate required parameters in
 inet6_validate_link_af

From: Maxim Mikityanskiy <maximmi@...lanox.com>
Date: Tue, 21 May 2019 06:40:04 +0000

> inet6_set_link_af requires that at least one of IFLA_INET6_TOKEN or
> IFLA_INET6_ADDR_GET_MODE is passed. If none of them is passed, it
> returns -EINVAL, which may cause do_setlink() to fail in the middle of
> processing other commands and give the following warning message:
> 
>   A link change request failed with some changes committed already.
>   Interface eth0 may have been left with an inconsistent configuration,
>   please check.
> 
> Check the presence of at least one of them in inet6_validate_link_af to
> detect invalid parameters at an early stage, before do_setlink does
> anything. Also validate the address generation mode at an early stage.
> 
> Signed-off-by: Maxim Mikityanskiy <maximmi@...lanox.com>

Applied, thank you.