lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 22 May 2019 13:29:45 -0700
From:   Florian Fainelli <>
To:     Heiner Kallweit <>,
        Madalin-cristian Bucur <>,
        Shawn Guo <>, Li Yang <>,
        Rob Herring <>,
        Mark Rutland <>,
        Andrew Lunn <>,
        David Miller <>
Cc:     "" <>,
        "" <>
Subject: Re: [PATCH net-next 2/2] net: phy: aquantia: add USXGMII support

On 5/22/19 1:18 PM, Heiner Kallweit wrote:
> On 22.05.2019 22:07, Florian Fainelli wrote:
>> On 5/22/19 12:58 PM, Heiner Kallweit wrote:
>>> So far we didn't support mode USXGMII, and in order to not break the
>>> two Freescale boards mode XGMII was accepted for the AQR107 family
>>> even though it doesn't support XGMII. Add USXGMII support to the
>>> Aquantia PHY driver and change the phy connection type for the two
>>> boards.
>>> As an additional note: Even though the handle is named aqr106
>>> there seem to be LS1046A boards with an AQR107.
>>> Signed-off-by: Heiner Kallweit <>
>> You can probably split the DTS changes and the PHY driver changes into a
>> separate commits and just have the DTS changes come last? With that:
> To split the patches I would have to do:
> 1. Add USXGMII support to Aquantia PHY driver
> 2. DTS changes
> 3. Don't accept XGMII any longer in Aquantia PHY driver
> This seemed to me to be too much overhead considering the very small
> change.
> Just making the DTS changes a separate patch would break bisecting.

I fail to see how, you can't make use of "usxgmii" in DTS unless you
define that as as a valid phy-mode property value (patch #1), and you
can't have that possibly working until patch #2. Until then using
"xgmii" is still supported and going to work.

Once patch #3 which brings DTS lands in, you could possibly deprecate
"xgmii" in the Aquantia PHY driver (or rather issue a big warning).

Powered by blists - more mailing lists