netdev - Re: [PATCH bpf-next 3/3] selftests/bpf: add pyperf scale test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2a067f93-c607-34fc-1c34-611ed4a8f6a0@fb.com>
Date:   Wed, 22 May 2019 00:49:56 +0000
From:   Alexei Starovoitov <ast@...com>
To:     Andrii Nakryiko <andrii.nakryiko@...il.com>,
        Alexei Starovoitov <ast@...nel.org>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        Daniel Borkmann <daniel@...earbox.net>,
        Networking <netdev@...r.kernel.org>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        Kernel Team <Kernel-team@...com>
Subject: Re: [PATCH bpf-next 3/3] selftests/bpf: add pyperf scale test

On 5/21/19 5:36 PM, Andrii Nakryiko wrote:
>> --- /dev/null
>> +++ b/tools/testing/selftests/bpf/progs/pyperf.h
>> @@ -0,0 +1,268 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +// Copyright (c) 2019 Facebook
> 
> Maybe let's include a link to an up-to-date real tool, that was used
> to create this scale test in BCC:
> https://github.com/iovisor/bcc/blob/master/examples/cpp/pyperf/PyPerfBPFProgram.cc

I thought about it, but decided not to,
since this hack is not exactly the same.
I tried to keep an idea of the loop though
with roughly the same number of probe_reads
and 'if' conditions, but was chopping all bcc-ism out of it.
In the commit log: "Add a snippet of pyperf bpf program"
By "a snippet" I meant that it's not the same thing,
but close enough from verifier complexity point of view.
Existing pyperf works around the lack of loops with tail-calls :(
I'm thinking to reuse this hack as future bounded loop test too.

Another reason to avoid the link is I'm hoping that pyperf
will move from 'examples' directory there into proper tool,
so the link will become broken.