netdev - Re: [PATCH bpf-next 1/3] bpf: cleanup explored

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190521180403.0a24e0e9@cakuba.netronome.com>
Date:   Tue, 21 May 2019 18:04:03 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Alexei Starovoitov <ast@...nel.org>
Cc:     <davem@...emloft.net>, <daniel@...earbox.net>,
        <netdev@...r.kernel.org>, <bpf@...r.kernel.org>,
        <kernel-team@...com>
Subject: Re: [PATCH bpf-next 1/3] bpf: cleanup explored_states

On Tue, 21 May 2019 16:06:33 -0700, Alexei Starovoitov wrote:
> clean up explored_states to prep for introduction of hashtable
> No functional changes.
> 
> Signed-off-by: Alexei Starovoitov <ast@...nel.org>
> ---
>  kernel/bpf/verifier.c | 30 +++++++++++++++++++++---------
>  1 file changed, 21 insertions(+), 9 deletions(-)
> 
> diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
> index 95f9354495ad..a171b2940382 100644
> --- a/kernel/bpf/verifier.c
> +++ b/kernel/bpf/verifier.c
> @@ -5436,6 +5436,18 @@ enum {
>  };
>  
>  #define STATE_LIST_MARK ((struct bpf_verifier_state_list *) -1L)
> +static struct bpf_verifier_state_list **explored_state(
> +					struct bpf_verifier_env *env,
> +					int idx)
> +{
> +	return &env->explored_states[idx];
> +}
> +
> +static void init_explored_state(struct bpf_verifier_env *env, int idx)
> +{
> +	env->explored_states[idx] = STATE_LIST_MARK;
> +}
> +

nit: extra new line here

>