netdev - Re: [PATCH V3] hsr: fix don't prune the master node from the node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1ce497cb-f121-7f73-e39f-a0474a33bc90@cogentembedded.com>
Date:   Thu, 23 May 2019 12:02:00 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Andreas Oetken <andreas.oetken@...mens.com>
Cc:     andreas@...ken.name, m-karicheri2@...com, a-kramer@...com,
        Arvid Brodin <arvid.brodin@...en.se>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH V3] hsr: fix don't prune the master node from the node_db

Hello!

On 23.05.2019 10:02, Andreas Oetken wrote:

> Don't prune master node in the hsr_prune_nodes function.
> Neither time_in[HSR_PT_SLAVE_A], nor time_in[HSR_PT_SLAVE_B],
> will ever be updated by hsr_register_frame_in for the master port.
> Thus the master node will be repeatedly pruned leading to
> repeated packet loss.
> This bug never appeared because the hsr_prune_nodes function
> was only called once. Since commit 5150b45fd355
> ("net: hsr: Fix node prune function for forget time expiry") this issue
> is fixed unvealing the issue described above.
            ^^^^^^^^^
    My spellchecker trips on this word. I think it should be either 
"unveiling" or "revealing"...

>  Fixes: 5150b45fd355 ("net: hsr: Fix node prune function for forget time expiry")
> Signed-off-by: Andreas Oetken <andreas.oetken@...mens.com>
> Tested-by: Murali Karicheri <m-karicheri2@...com>
[...]

MBR, Sergei