netdev - Re: [PATCH] mISDN: make sure device name is NUL terminated

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190522.172230.230166759225525041.davem@davemloft.net>
Date:   Wed, 22 May 2019 17:22:30 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     dan.carpenter@...cle.com
Cc:     isdn@...ux-pingi.de, zhongjiang@...wei.com, deepa.kernel@...il.com,
        penguin-kernel@...ove.SAKURA.ne.jp, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] mISDN: make sure device name is NUL terminated

From: Dan Carpenter <dan.carpenter@...cle.com>
Date: Wed, 22 May 2019 11:45:13 +0300

> The user can change the device_name with the IMSETDEVNAME ioctl, but we
> need to ensure that the user's name is NUL terminated.  Otherwise it
> could result in a buffer overflow when we copy the name back to the user
> with IMGETDEVINFO ioctl.
> 
> I also changed two strcpy() calls which handle the name to strscpy().
> Hopefully, there aren't any other ways to create a too long name, but
> it's nice to do this as a kernel hardening measure.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Applied.