netdev - Re: [PATCH net-next] selftests: pmtu: Simplify cleanup and namespace names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 22 May 2019 17:55:57 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     dsahern@...nel.org
Cc:     netdev@...r.kernel.org, sbrivio@...hat.com, dsahern@...il.com
Subject: Re: [PATCH net-next] selftests: pmtu: Simplify cleanup and
 namespace names

From: David Ahern <dsahern@...nel.org>
Date: Wed, 22 May 2019 12:11:06 -0700

> From: David Ahern <dsahern@...il.com>
> 
> The point of the pause-on-fail argument is to leave the setup as is after
> a test fails to allow a user to debug why it failed. Move the cleanup
> after posting the result to the user to make it so.
> 
> Random names for the namespaces are not user friendly when trying to
> debug a failure. Make them simpler and more direct for the tests. Run
> cleanup at the beginning to ensure they are cleaned up if they already
> exist.
> 
> Remove cleanup_done. There is no harm in doing cleanup twice; just
> ignore any errors related to not existing - which is already done.
> 
> Signed-off-by: David Ahern <dsahern@...il.com>

Applied.