netdev - Re: [PATCH 2/2] net: macb: Add support for SiFive FU540-C000

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190523145417.GD19369@lunn.ch>
Date:   Thu, 23 May 2019 16:54:17 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Yash Shah <yash.shah@...ive.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org,
        devicetree@...r.kernel.org, robh+dt@...nel.org,
        mark.rutland@....com, nicolas.ferre@...rochip.com,
        palmer@...ive.com, aou@...s.berkeley.edu, ynezz@...e.cz,
        paul.walmsley@...ive.com, sachin.ghadi@...ive.com
Subject: Re: [PATCH 2/2] net: macb: Add support for SiFive FU540-C000

> +static int fu540_macb_tx_set_rate(struct clk_hw *hw, unsigned long rate,
> +				  unsigned long parent_rate)
> +{
> +	rate = fu540_macb_tx_round_rate(hw, rate, &parent_rate);
> +	iowrite32(rate != 125000000, mgmt->reg);

That looks odd. Writing the result of a comparison to a register?

     Andrew