netdev - Re: [RFC PATCH net-next 0/9] Decoupling PHYLINK from struct net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 23 May 2019 17:12:12 +0200
From:   Maxime Chevallier <maxime.chevallier@...tlin.com>
To:     Ioana Ciornei <ioana.ciornei@....com>
Cc:     "linux@...linux.org.uk" <linux@...linux.org.uk>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>,
        "andrew@...n.ch" <andrew@...n.ch>,
        "hkallweit1@...il.com" <hkallweit1@...il.com>,
        "olteanv@...il.com" <olteanv@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>
Subject: Re: [RFC PATCH net-next 0/9] Decoupling PHYLINK from struct
 net_device

Hello Ioana,

On Thu, 23 May 2019 01:20:36 +0000
Ioana Ciornei <ioana.ciornei@....com> wrote:

>Following two separate discussion threads in:
>  https://www.spinics.net/lists/netdev/msg569087.html
>and:
>  https://www.spinics.net/lists/netdev/msg570450.html
>
>PHYLINK was reworked in order to add a new "raw" interface, alongside
>the one based on struct net_device. The raw interface works by passing
>structures to the owner of the phylink instance through a blocking
>notifier call.
>
>The event API exposed by the new notifier mechanism is a 1:1 mapping to
>the existing PHYLINK mac_ops, plus the PHYLINK fixed-link callback.
>
>PHYLIB (which PHYLINK uses) was reworked to the extent that it does not
>crash when connecting to a PHY and the net_device pointer is NULL.
>
>Lastly, DSA has been reworked in its way that it handles PHYs for ports
>that lack a net_device (CPU and DSA ports).  For these, it was
>previously using PHYLIB and is now using the PHYLINK raw API.

Thanks for this series, I've tested it and it does address the
particular issue I having, with the DSA fixed-link CPU port. I've been
able to use 2500 and 10000 Mbps links with your series, on a board
using a 88e6390X (so, the mv88e6xxx driver).

I've also tested it on boards using PPv2, which uses phylink, and
didn't spot any issue, so this looks fine.

I'll be happy to test future versions,

Thanks,

Maxime