netdev - Re: [PATCH net] ipv6: Fix redirect with VRF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 22 May 2019 17:59:04 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     dsahern@...nel.org
Cc:     netdev@...r.kernel.org, dsahern@...il.com
Subject: Re: [PATCH net] ipv6: Fix redirect with VRF

From: David Ahern <dsahern@...nel.org>
Date: Wed, 22 May 2019 15:12:18 -0700

> From: David Ahern <dsahern@...il.com>
> 
> IPv6 redirect is broken for VRF. __ip6_route_redirect walks the FIB
> entries looking for an exact match on ifindex. With VRF the flowi6_oif
> is updated by l3mdev_update_flow to the l3mdev index and the
> FLOWI_FLAG_SKIP_NH_OIF set in the flags to tell the lookup to skip the
> device match. For redirects the device match is requires so use that
> flag to know when the oif needs to be reset to the skb device index.
> 
> Fixes: ca254490c8df ("net: Add VRF support to IPv6 stack")
> Signed-off-by: David Ahern <dsahern@...il.com>

Applied and queued up for -stable.