netdev - Re: [PATCH V4] hsr: fix don't prune the master node from the node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190523.093031.456990380849413310.davem@davemloft.net>
Date:   Thu, 23 May 2019 09:30:31 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     andreas.oetken@...mens.com
Cc:     andreas@...ken.name, m-karicheri2@...com, a-kramer@...com,
        arvid.brodin@...en.se, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH V4] hsr: fix don't prune the master node from the
 node_db

From: Andreas Oetken <andreas.oetken@...mens.com>
Date: Thu, 23 May 2019 13:57:14 +0200

> Don't prune the master node in the hsr_prune_nodes function.
> Neither time_in[HSR_PT_SLAVE_A] nor time_in[HSR_PT_SLAVE_B]
> will ever be updated by hsr_register_frame_in for the master port.
> Thus, the master node will be repeatedly pruned leading to
> repeated packet loss.
> This bug never appeared because the hsr_prune_nodes function
> was only called once. Since commit 5150b45fd355
> ("net: hsr: Fix node prune function for forget time expiry") this issue
> is fixed unveiling the issue described above.
> 
> Fixes: 5150b45fd355 ("net: hsr: Fix node prune function for forget time expiry")
> Signed-off-by: Andreas Oetken <andreas.oetken@...mens.com>
> Tested-by: Murali Karicheri <m-karicheri2@...com>

Applied.