netdev - Re: [PATCH bpf-next v2 RESEND 0/2] Move bpf_printk to bpf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4642ca96-22ab-ad61-a6a1-1d2ef7239cb8@fb.com>
Date:   Thu, 23 May 2019 16:51:20 +0000
From:   Yonghong Song <yhs@...com>
To:     Michal Rostecki <mrostecki@...nsuse.org>
CC:     Shuah Khan <shuah@...nel.org>, Alexei Starovoitov <ast@...nel.org>,
        "Daniel Borkmann" <daniel@...earbox.net>,
        Martin Lau <kafai@...com>, Song Liu <songliubraving@...com>,
        "David S. Miller" <davem@...emloft.net>,
        "Jakub Kicinski" <jakub.kicinski@...ronome.com>,
        Jesper Dangaard Brouer <hawk@...nel.org>,
        John Fastabend <john.fastabend@...il.com>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@...r.kernel.org>,
        "open list:BPF (Safe dynamic programs and tools)" 
        <netdev@...r.kernel.org>,
        "open list:BPF (Safe dynamic programs and tools)" 
        <bpf@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>,
        "open list:XDP (eXpress Data Path)" <xdp-newbies@...r.kernel.org>
Subject: Re: [PATCH bpf-next v2 RESEND 0/2] Move bpf_printk to bpf_helpers.h



On 5/23/19 5:53 AM, Michal Rostecki wrote:
> This series of patches move the commonly used bpf_printk macro to
> bpf_helpers.h which is already included in all BPF programs which
> defined that macro on their own.
> 
> v1->v2:
> - If HBM_DEBUG is not defined in hbm sample, undefine bpf_printk and set
>    an empty macro for it.
> 
> Michal Rostecki (2):
>    selftests: bpf: Move bpf_printk to bpf_helpers.h
>    samples: bpf: Do not define bpf_printk macro
> 
>   samples/bpf/hbm_kern.h                                | 11 ++---------
>   samples/bpf/tcp_basertt_kern.c                        |  7 -------
>   samples/bpf/tcp_bufs_kern.c                           |  7 -------
>   samples/bpf/tcp_clamp_kern.c                          |  7 -------
>   samples/bpf/tcp_cong_kern.c                           |  7 -------
>   samples/bpf/tcp_iw_kern.c                             |  7 -------
>   samples/bpf/tcp_rwnd_kern.c                           |  7 -------
>   samples/bpf/tcp_synrto_kern.c                         |  7 -------
>   samples/bpf/tcp_tos_reflect_kern.c                    |  7 -------
>   samples/bpf/xdp_sample_pkts_kern.c                    |  7 -------
>   tools/testing/selftests/bpf/bpf_helpers.h             |  8 ++++++++
>   .../testing/selftests/bpf/progs/sockmap_parse_prog.c  |  7 -------
>   .../selftests/bpf/progs/sockmap_tcp_msg_prog.c        |  7 -------
>   .../selftests/bpf/progs/sockmap_verdict_prog.c        |  7 -------
>   .../testing/selftests/bpf/progs/test_lwt_seg6local.c  |  7 -------
>   tools/testing/selftests/bpf/progs/test_xdp_noinline.c |  7 -------
>   tools/testing/selftests/bpf/test_sockmap_kern.h       |  7 -------
>   17 files changed, 10 insertions(+), 114 deletions(-)

Ack for the whole series.
Acked-by: Yonghong Song <yhs@...com>