netdev - Re: [PATCH net] ipv4/igmp: fix another memory leak in igmpv3_del

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 22 May 2019 18:05:14 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com,
        liuhangbin@...il.com, syzkaller@...glegroups.com
Subject: Re: [PATCH net] ipv4/igmp: fix another memory leak in
 igmpv3_del_delrec()

From: Eric Dumazet <edumazet@...gle.com>
Date: Wed, 22 May 2019 16:51:22 -0700

> syzbot reported memory leaks [1] that I have back tracked to
> a missing cleanup from igmpv3_del_delrec() when
> (im->sfmode != MCAST_INCLUDE)
> 
> Add ip_sf_list_clear_all() and kfree_pmc() helpers to explicitely
> handle the cleanups before freeing.
> 
> [1]
 ...
> Fixes: 9c8bb163ae78 ("igmp, mld: Fix memory leak in igmpv3/mld_del_delrec()")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Hangbin Liu <liuhangbin@...il.com>
> Reported-by: syzbot <syzkaller@...glegroups.com>

Applied and queued up for -stable, thanks Eric.