netdev - Re: [RESEND PATCH] intel-ethernet: warn when fatal read failure happens

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f8d774415fcb66c46ebc08a9b66f32d825c004ac.camel@intel.com>
Date:   Thu, 23 May 2019 15:55:15 -0700
From:   Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:     Feng Tang <feng.tang@...el.com>,
        Sasha Neftin <sasha.neftin@...el.com>,
        Aaron F Brown <aaron.f.brown@...el.com>,
        intel-wired-lan@...osl.org, netdev@...r.kernel.org
Subject: Re: [RESEND PATCH] intel-ethernet: warn when fatal read failure
 happens

On Thu, 2019-05-23 at 11:22 +0800, Feng Tang wrote:
> Failed in reading the HW register is very serious for igb/igc driver,
> as its hw_addr will be set to NULL and cause the adapter be seen as
> "REMOVED".
> 
> We saw the error only a few times in the MTBF test for
> suspend/resume,
> but can hardly get any useful info to debug.
> 
> Adding WARN() so that we can get the necessary information about
> where and how it happens, and use it for root causing and fixing
> this "PCIe link lost issue"
> 
> This affects igb, igc.
> 
> Signed-off-by: Feng Tang <feng.tang@...el.com>
> Tested-by: Aaron Brown <aaron.f.brown@...el.com>
> Acked-by: Sasha Neftin <sasha.neftin@...el.com>
> ---
>  drivers/net/ethernet/intel/igb/igb_main.c | 1 +
>  drivers/net/ethernet/intel/igc/igc_main.c | 1 +
>  2 files changed, 2 insertions(+)

This patch is already in my next series of 1GbE patches to push to
Dave, so you can expect this to be pushed upstream before the weekend.

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)