lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 23 May 2019 23:43:00 +0000 From: Roman Gushchin <guro@...com> To: Yonghong Song <yhs@...com> CC: Alexei Starovoitov <ast@...nel.org>, "bpf@...r.kernel.org" <bpf@...r.kernel.org>, Daniel Borkmann <daniel@...earbox.net>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Tejun Heo <tj@...nel.org>, Kernel Team <Kernel-team@...com>, "cgroups@...r.kernel.org" <cgroups@...r.kernel.org>, Stanislav Fomichev <sdf@...ichev.me>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v3 bpf-next 4/4] selftests/bpf: add auto-detach test On Thu, May 23, 2019 at 04:09:30PM -0700, Yonghong Song wrote: > > > On 5/23/19 12:45 PM, Roman Gushchin wrote: > > Add a kselftest to cover bpf auto-detachment functionality. > > The test creates a cgroup, associates some resources with it, > > attaches a couple of bpf programs and deletes the cgroup. > > > > Then it checks that bpf programs are going away in 5 seconds. > > > > Expected output: > > $ ./test_cgroup_attach > > #override:PASS > > #multi:PASS > > #autodetach:PASS > > test_cgroup_attach:PASS > > > > On a kernel without auto-detaching: > > $ ./test_cgroup_attach > > #override:PASS > > #multi:PASS > > #autodetach:FAIL > > test_cgroup_attach:FAIL > > > > Signed-off-by: Roman Gushchin <guro@...com> > > Looks good to me. It will be good if you can add test_cgroup_attach > to .gitignore to avoid it shows up in `git status`. With that, I don't think it deserves a new version, I'll prepare a separate patch for it. > > Acked-by: Yonghong Song <yhs@...com> Thank you for the review!
Powered by blists - more mailing lists