lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <cef9c200-4bbd-db3e-1e28-f7cf16df0faf@gmail.com> Date: Wed, 22 May 2019 19:13:01 -0700 From: Florian Fainelli <f.fainelli@...il.com> To: Ioana Ciornei <ioana.ciornei@....com>, "linux@...linux.org.uk" <linux@...linux.org.uk>, "andrew@...n.ch" <andrew@...n.ch>, "hkallweit1@...il.com" <hkallweit1@...il.com>, "maxime.chevallier@...tlin.com" <maxime.chevallier@...tlin.com>, "olteanv@...il.com" <olteanv@...il.com> Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "davem@...emloft.net" <davem@...emloft.net> Subject: Re: [RFC PATCH net-next 7/9] net: dsa: Move the phylink driver calls into port.c On 5/22/2019 6:20 PM, Ioana Ciornei wrote: > In order to have a common handling of PHYLINK for the slave and non-user > ports, the DSA core glue logic (between PHYLINK and the driver) must use > an API that does not rely on a struct net_device. > > These will also be called by the CPU-port-handling code in a further > patch. > > Signed-off-by: Ioana Ciornei <ioana.ciornei@....com> > Suggested-by: Vladimir Oltean <olteanv@...il.com> > --- [snip] > +void dsa_port_phylink_validate(struct dsa_port *dp, > + unsigned long *supported, > + struct phylink_link_state *state) > +{ > + struct dsa_switch *ds = dp->ds; > + > + if (!ds->ops->phylink_validate) > + return; > + > + ds->ops->phylink_validate(ds, dp->index, supported, state); > +} > +EXPORT_SYMBOL(dsa_port_phylink_validate); Those exports should probably be _GPL to follow the PHYLINK exports but other than that: Reviewed-by: Florian Fainelli <f.fainelli@...il.com> -- Florian
Powered by blists - more mailing lists