netdev - Re: [PATCH net-next 0/7] ipv6: Move exceptions to fib6_nh and make it optional in a fib6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190524.132839.1622018394749383575.davem@davemloft.net>
Date:   Fri, 24 May 2019 13:28:39 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     dsahern@...nel.org
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com,
        idosch@...lanox.com, dsahern@...il.com
Subject: Re: [PATCH net-next 0/7] ipv6: Move exceptions to fib6_nh and make
 it optional in a fib6_info

From: David Ahern <dsahern@...nel.org>
Date: Wed, 22 May 2019 20:27:54 -0700

> From: David Ahern <dsahern@...il.com>
> 
> Patches 1 and 4 move pcpu and exception caches from fib6_info to fib6_nh.
> With respect to the current FIB entries this is only a movement from one
> struct to another contained within the first.
> 
> Patch 2 refactors the core logic of fib6_drop_pcpu_from into a helper
> that is invoked per fib6_nh.
> 
> Patch 3 refactors exception handling in a similar way - creating a bunch
> of helpers that can be invoked per fib6_nh with the goal of making patch
> 4 easier to review as well as creating the code needed for nexthop
> objects.
> 
> Patch 5 makes a fib6_nh at the end of a fib6_info an array similar to
> IPv4 and its fib_info. For the current fib entry model, all fib6_info
> will have a fib6_nh allocated for it.
> 
> Patch 6 refactors ip6_route_del moving the code for deleting an
> exception entry into a new function.
> 
> Patch 7 adds tests for redirect route exceptions. The new test was
> written against 5.1 (before any of the nexthop refactoring). It and the
> pmtu.sh selftest exercise the exception code paths - from creating
> exceptions to cleaning them up on device delete. All tests pass without
> any rcu locking or memleak warnings.

Series applied, thanks David.