netdev - Re: [PATCH net-next v2] selftests/net: SO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190524.133511.953468514937709206.davem@davemloft.net>
Date:   Fri, 24 May 2019 13:35:11 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     willemdebruijn.kernel@...il.com
Cc:     netdev@...r.kernel.org, edumazet@...gle.com, willemb@...gle.com
Subject: Re: [PATCH net-next v2] selftests/net: SO_TXTIME with ETF and FQ

From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
Date: Thu, 23 May 2019 13:48:46 -0400

> From: Willem de Bruijn <willemb@...gle.com>
> 
> The SO_TXTIME API enables packet tranmission with delayed delivery.
> This is currently supported by the ETF and FQ packet schedulers.
> 
> Evaluate the interface with both schedulers. Install the scheduler
> and send a variety of packets streams: without delay, with one
> delayed packet, with multiple ordered delays and with reordering.
> Verify that packets are released by the scheduler in expected order.
> 
> The ETF qdisc requires a timestamp in the future on every packet. It
> needs a delay on the qdisc else the packet is dropped on dequeue for
> having a delivery time in the past. The test value is experimentally
> derived. ETF requires clock_id CLOCK_TAI. It checks this base and
> drops for non-conformance.
> 
> The FQ qdisc expects clock_id CLOCK_MONOTONIC, the base used by TCP
> as of commit fb420d5d91c1 ("tcp/fq: move back to CLOCK_MONOTONIC").
> Within a flow there is an expecation of ordered delivery, as shown by
> delivery times of test 4. The FQ qdisc does not require all packets to
> have timestamps and does not drop for non-conformance.
> 
> The large (msec) delays are chosen to avoid flakiness.
 ...
> Changes v1->v2: update commit message output
> 
> Signed-off-by: Willem de Bruijn <willemb@...gle.com>
> Acked-by: Eric Dumazet <edumazet@...gle.com>

Applied, thanks Willem.