netdev - Re: [PATCH][next] ipv4: remove redundant assignment to n

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 24 May 2019 16:04:54 -0600
From:   David Ahern <dsahern@...il.com>
To:     Colin King <colin.king@...onical.com>,
        "David S . Miller" <davem@...emloft.net>,
        Alexey Kuznetsov <kuznet@....inr.ac.ru>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        netdev@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] ipv4: remove redundant assignment to n

On 5/24/19 3:56 PM, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The pointer n is being assigned a value however this value is
> never read in the code block and the end of the code block
> continues to the next loop iteration. Clean up the code by
> removing the redundant assignment.
> 
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  net/ipv4/fib_trie.c | 1 -
>  1 file changed, 1 deletion(-)
> 

This looks right to me -- n should have been dropped. It is used in
fib_trie_free from which I created  __fib_info_notify_update but
__fib_info_notify_update does do the put_child_root or node_free, it
only walks the tree looking for relevant entries that need to send the
NEWROUTE notifications.

Fixes: 1bff1a0c9bbda ("ipv4: Add function to send route updates")
Reviewed-by: David Ahern <dsahern@...il.com>