netdev - re: net: ll_temac: Cleanup multicast filter on change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <6b57d3a1-98b6-c20d-355d-87c2f52b0f31@canonical.com>
Date:   Fri, 24 May 2019 23:41:24 +0100
From:   Colin Ian King <colin.king@...onical.com>
To:     "David S. Miller" <davem@...emloft.net>,
        Esben Haabendal <esben@...nix.com>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        linux-arm-kernel@...ts.infradead.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: re: net: ll_temac: Cleanup multicast filter on change

Hi,

static analysis with Coverity has detected a potential issue with the
following commit:

commit 1b3fa5cf859bce7094ac18d32f54af8a7148ad51
Author: Esben Haabendal <esben@...nix.com>
Date:   Thu May 23 14:02:21 2019 +0200

    net: ll_temac: Cleanup multicast filter on change

In function temac_set_multicast_list
(drivers/net/ethernet/xilinx/ll_temac_main.c), loop counter i is *only*
initialized in the code block:

	if (!netdev_mc_empty(ndev)) {
		...
	}

Following this if code block there is a while-loop that iterates using i
as counter which will be problematic if i has not been correctly
initialized:

        while (i < MULTICAST_CAM_TABLE_NUM) {
                temac_indirect_out32_locked(lp, XTE_MAW0_OFFSET, 0);
                temac_indirect_out32_locked(lp, XTE_MAW1_OFFSET, i << 16);
                i++;
        }

Colin