netdev - Re: [patch net-next 0/7] expose flash update status to user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190524081510.GD2904@nanopsycho>
Date:   Fri, 24 May 2019 10:15:10 +0200
From:   Jiri Pirko <jiri@...nulli.us>
To:     Saeed Mahameed <saeedm@...lanox.com>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "sthemmin@...rosoft.com" <sthemmin@...rosoft.com>,
        "dsahern@...il.com" <dsahern@...il.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        mlxsw <mlxsw@...lanox.com>,
        "jakub.kicinski@...ronome.com" <jakub.kicinski@...ronome.com>,
        "leon@...nel.org" <leon@...nel.org>
Subject: Re: [patch net-next 0/7] expose flash update status to user

Thu, May 23, 2019 at 08:37:28PM CEST, saeedm@...lanox.com wrote:
>On Thu, 2019-05-23 at 11:45 +0200, Jiri Pirko wrote:
>> From: Jiri Pirko <jiri@...lanox.com>
>> 
>> When user is flashing device using devlink, he currenly does not see
>> any
>> information about what is going on, percentages, etc.
>> Drivers, for example mlxsw and mlx5, have notion about the progress
>> and what is happening. This patchset exposes this progress
>> information to userspace.
>> 
>
>Very cool stuff, \let's update devlink docs with the new potential
>output of the fw flash commands, and show us some output example here
>or on one of the commit messages, it would really help getting an idea
>of what this cool patchset provides. 

You mean in man? I can put some example there.


>
>> See this console recording which shows flashing FW on a Mellanox
>> Spectrum device:
>> https://asciinema.org/a/247926
>> 
>> Jiri Pirko (7):
>>   mlxsw: Move firmware flash implementation to devlink
>>   mlx5: Move firmware flash implementation to devlink
>>   mlxfw: Propagate error messages through extack
>>   devlink: allow driver to update progress of flash update
>>   mlxfw: Introduce status_notify op and call it to notify about the
>>     status
>>   mlxsw: Implement flash update status notifications
>>   netdevsim: implement fake flash updating with notifications
>> 
>>  drivers/net/ethernet/mellanox/mlx5/core/en.h  |   2 -
>>  .../ethernet/mellanox/mlx5/core/en_ethtool.c  |  35 ------
>>  drivers/net/ethernet/mellanox/mlx5/core/fw.c  |   6 +-
>>  .../mellanox/mlx5/core/ipoib/ethtool.c        |   9 --
>>  .../net/ethernet/mellanox/mlx5/core/main.c    |  20 ++++
>>  .../ethernet/mellanox/mlx5/core/mlx5_core.h   |   3 +-
>>  drivers/net/ethernet/mellanox/mlxfw/mlxfw.h   |  11 +-
>>  .../net/ethernet/mellanox/mlxfw/mlxfw_fsm.c   |  57 ++++++++--
>>  drivers/net/ethernet/mellanox/mlxsw/core.c    |  15 +++
>>  drivers/net/ethernet/mellanox/mlxsw/core.h    |   3 +
>>  .../net/ethernet/mellanox/mlxsw/spectrum.c    |  75 +++++++------
>>  drivers/net/netdevsim/dev.c                   |  35 ++++++
>>  include/net/devlink.h                         |   8 ++
>>  include/uapi/linux/devlink.h                  |   5 +
>>  net/core/devlink.c                            | 102
>> ++++++++++++++++++
>>  15 files changed, 295 insertions(+), 91 deletions(-)
>> 
>
>Reviewed-by: Saeed Mahameed <saeedm@...lanox.com>