netdev - Re: [PATCH net] net: dsa: mv88e6xxx: Set correct interface mode for CPU/DSA ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <e27eeebb-44fb-ae42-d43d-b42b47510f76@kernel.org>
Date:   Fri, 24 May 2019 11:25:03 +1000
From:   Greg Ungerer <gerg@...nel.org>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net] net: dsa: mv88e6xxx: Set correct interface mode for
 CPU/DSA ports

Hi Andrew,

I have a problem with a Marvell 6390 switch that I have bisected
back to commit 7cbbee050c95, "[PATCH] net: dsa: mv88e6xxx: Set correct
interface mode for CPU/DSA ports".

I have a Marvell 380 SoC based platform with a Marvell 6390 10 port
switch, everything works with kernel 5.0 and older. As of 5.1 the
switch ports no longer work - no packets are ever received and
none get sent out.

The ports are probed and all discovered ok, they just don't work.

   mv88e6085 f1072004.mdio-mii:10: switch 0x3900 detected: Marvell 88E6390, revision 1
   libphy: mv88e6xxx SMI: probed
   mv88e6085 f1072004.mdio-mii:10 lan1 (uninitialized): PHY [mv88e6xxx-1:01] driver [Marvell 88E6390]
   mv88e6085 f1072004.mdio-mii:10 lan2 (uninitialized): PHY [mv88e6xxx-1:02] driver [Marvell 88E6390]
   mv88e6085 f1072004.mdio-mii:10 lan3 (uninitialized): PHY [mv88e6xxx-1:03] driver [Marvell 88E6390]
   mv88e6085 f1072004.mdio-mii:10 lan4 (uninitialized): PHY [mv88e6xxx-1:04] driver [Marvell 88E6390]
   mv88e6085 f1072004.mdio-mii:10 lan5 (uninitialized): PHY [mv88e6xxx-1:05] driver [Marvell 88E6390]
   mv88e6085 f1072004.mdio-mii:10 lan6 (uninitialized): PHY [mv88e6xxx-1:06] driver [Marvell 88E6390]
   mv88e6085 f1072004.mdio-mii:10 lan7 (uninitialized): PHY [mv88e6xxx-1:07] driver [Marvell 88E6390]
   mv88e6085 f1072004.mdio-mii:10 lan8 (uninitialized): PHY [mv88e6xxx-1:08] driver [Marvell 88E6390]
   DSA: tree 0 setup

Things like ethtool on the ports seem to work ok, reports link correctly.
Configuring ports as part of a bridge or individually gets the same result.

Reverting just this single commit gets the ports working again
with a linux-5.1 kernel.

Any ideas?

Regards
Greg