netdev - Re: [PATCH net-next] udp: Avoid post-GRO UDP checksum recalculation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190525.105325.1113754964856663524.davem@davemloft.net>
Date:   Sat, 25 May 2019 10:53:25 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     stranche@...eaurora.org
Cc:     netdev@...r.kernel.org, pabeni@...hat.com, subashab@...eaurora.org
Subject: Re: [PATCH net-next] udp: Avoid post-GRO UDP checksum recalculation

From: Sean Tranchetti <stranche@...eaurora.org>
Date: Thu, 23 May 2019 13:36:17 -0600

> @@ -472,11 +472,15 @@ static inline struct sk_buff *udp_rcv_segment(struct sock *sk,
>  					      struct sk_buff *skb, bool ipv4)
>  {
>  	struct sk_buff *segs;
> +	netdev_features_t features = NETIF_F_SG;

When you respin this based upon Paolo's feedback, please reverse christmas
tree these local variables.

Thank you.